Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the scope markdown generator by registering two new document scopes as sensitive and suggesting alternative non-sensitive scopes that share the same prefix.
- Adds
https://www.googleapis.com/auth/documentsand.../documents.readonlytoSENSITIVE_SCOPES. - Implements suggestion logic in
getScopeMarkdownto list non-sensitive scopes with the full shared prefix. - Introduces a helper
getSharedPrefixfunction.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/scopes.ts | Added document scopes, suggestion collection & sorting, plus getSharedPrefix utility |
| .changeset/eager-colts-peel.md | Created changeset entry for the new feature |
Comments suppressed due to low confidence (3)
src/scopes.ts:225
- [nitpick] This destructured
idshadows the outer function parameterid, which can be confusing. Consider renaming the loop variable to something likealtIdfor clarity.
for (const { id } of suggestions) {
src/scopes.ts:198
- The new suggestion-generation logic is not covered by existing tests. Consider adding unit tests to verify suggestion filtering, sorting, and edge cases.
const suggestions: { id: string; sharedPrefix: string }[] = [];
src/scopes.ts:246
- [nitpick] There’s no documentation for
getSharedPrefix. Adding a JSDoc comment explaining its purpose, parameters, and return value would improve readability.
function getSharedPrefix(a: string, b: string): string {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9